bowenli86 commented on a change in pull request #11538: [FLINK-16813][jdbc]
JDBCInputFormat doesn't correctly map Short
URL: https://github.com/apache/flink/pull/11538#discussion_r399029525
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
##########
@@ -110,8 +116,9 @@
private String queryTemplate;
private int resultSetType;
private int resultSetConcurrency;
- private RowTypeInfo rowTypeInfo;
+ private RowType rowType;
Review comment:
I haven't seen arguments to not use it in connectors. E.g.
HiveTableInputFormat uses DataType. And it's much nicer for connector to just
deal with user facing type system. What're your concerns?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
