bowenli86 commented on a change in pull request #11538: [FLINK-16813][jdbc]
JDBCInputFormat doesn't correctly map Short
URL: https://github.com/apache/flink/pull/11538#discussion_r399544519
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
##########
@@ -127,7 +134,7 @@ public JDBCInputFormat() {
@Override
public RowTypeInfo getProducedType() {
- return rowTypeInfo;
+ return (RowTypeInfo)
fromDataTypeToLegacyInfo(fromLogicalToDataType(rowType));
Review comment:
I think 1) keeping rowTypeInfo v.s. rowType and 2) have row converter as
runtime class, are orthogonal, right? I'd like to use new type system so it
won't need migration once flip-95 is done.
I agree keeping dialects out of runtime sounds like a better idea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
