Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1437#issuecomment-162580468
All in all quite good. Few things:
- The code style is super heterogeneous, sometimes it puts spaces after a
keyword, sometimes it does not. Would be good to make this straight.
- This mixes "Arrays.toString" and "StringUtils.join". Why not avail any
dependency on external libraries (with all the dependency conflicts, it is nice
to avoid where possible) and use
- `Arrays.toString()` for arrays.
- Simply `toString()` for lists.
- `KafkaTopicPartition` and `KafkaTopicPartitionLeader` need to be fast
for hash code and equals. They are used as hash map keys for every record
(offset update). Due to that, they should really be immutable types and cache
their hash code, since that is used for any record emitted (update in the
offsets hash map). Also, equals() should be fast.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
