pnowojski commented on a change in pull request #11529: 
[FLINK-16806][operators] Add support for InputSelection to 
MultipleInputStreamOperator
URL: https://github.com/apache/flink/pull/11529#discussion_r399274566
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/MultipleInputSelectionHandler.java
 ##########
 @@ -112,7 +112,7 @@ int selectNextInputIndex(int lastReadInputIndex) {
        }
 
        boolean shouldSetAvailableForAnotherInput() {
 
 Review comment:
   Do you have some proposal? `InputSelectable` is an interface for users to 
implement, to provide the chosen `InputSelection`. That gives as 
`inputSelector` from our perspective. Now we are wrapping some input selection 
handling logic into classes like `MultipleInputSelectionHandler`. How would you 
suggest to change it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to