AHeise commented on a change in pull request #11529: [FLINK-16806][operators]
Add support for InputSelection to MultipleInputStreamOperator
URL: https://github.com/apache/flink/pull/11529#discussion_r399316926
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/MultipleInputSelectionHandler.java
##########
@@ -112,7 +112,7 @@ int selectNextInputIndex(int lastReadInputIndex) {
}
boolean shouldSetAvailableForAnotherInput() {
- return availableInputsMask != allSelectedMask &&
inputSelection.areAllInputsSelected();
+ return (inputSelection.getInputMask() & allSelectedMask &
~availableInputsMask) != 0;
Review comment:
> What's the problem? I think performance wise it doesn't matter, the `&
allSelectedMask` would still need to be there somewhere on the critical path.
The point is that it would be moved out of the critical path. You only need
to do it once in the ctor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
