wuchong commented on a change in pull request #11482: [FLINK-16581][table]
Minibatch deduplication lack state TTL bug fix
URL: https://github.com/apache/flink/pull/11482#discussion_r399897112
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/deduplicate/MiniBatchDeduplicateKeepFirstRowFunction.java
##########
@@ -46,14 +47,18 @@
// state stores a boolean flag to indicate whether key appears before.
private ValueState<Boolean> state;
- public MiniBatchDeduplicateKeepFirstRowFunction(TypeSerializer<BaseRow>
typeSerializer) {
+ public MiniBatchDeduplicateKeepFirstRowFunction(TypeSerializer<BaseRow>
typeSerializer, long minRetentionTime) {
+ super(minRetentionTime);
this.typeSerializer = typeSerializer;
}
@Override
public void open(ExecutionContext ctx) throws Exception {
super.open(ctx);
ValueStateDescriptor<Boolean> stateDesc = new
ValueStateDescriptor<>("existsState", Types.BOOLEAN);
+ if (!stateTtlConfig.equals(StateTtlConfig.DISABLED)){
Review comment:
use `stateTtlConfig.isEnabled`. We should also correct the implementation in
`JoinRecordStateViews`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
