wuchong commented on a change in pull request #11482: [FLINK-16581][table]
Minibatch deduplication lack state TTL bug fix
URL: https://github.com/apache/flink/pull/11482#discussion_r400104417
##########
File path:
flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/deduplicate/MiniBatchDeduplicateKeepFirstRowFunctionTest.java
##########
@@ -71,4 +71,41 @@ public void testKeepFirstRowWithGenerateRetraction() throws
Exception {
testHarness.close();
}
+ @Test
+ public void tesKeepFirstRowWithStateTtl() throws Exception{
+ MiniBatchDeduplicateKeepFirstRowFunction func = new
MiniBatchDeduplicateKeepFirstRowFunction(typeSerializer,
minTime.toMilliseconds());
+ OneInputStreamOperatorTestHarness<BaseRow, BaseRow> testHarness
= createTestHarness(func);
+ testHarness.setup();
+ testHarness.open();
+ testHarness.processElement(record("book", 1L, 12));
+ testHarness.processElement(record("book", 2L, 11));
+ // output is empty because bundle not trigger yet.
+ Assert.assertTrue(testHarness.getOutput().isEmpty());
+ testHarness.processElement(record("book", 1L, 13));
+
+ Thread.sleep(30);
Review comment:
Hi @lsyldliu , I think a better way is to make
`StreamTaskStateInitializerImpl` accept a `TtlTimeProvider` constructor
parameter instead of hard code `TtlTimeProvider.DEFAULT` in the implementation.
Then, we can pass-in the `MockTtlTimeProvider` in
`AbstractStreamOperatorTestHarness#createStreamTaskStateManager`.
What do you think @Myasuka ? Could you help on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
