lsyldliu commented on a change in pull request #11482: [FLINK-16581][table]
Minibatch deduplication lack state TTL bug fix
URL: https://github.com/apache/flink/pull/11482#discussion_r399955912
##########
File path:
flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/deduplicate/MiniBatchDeduplicateKeepLastRowFunctionTest.java
##########
@@ -41,23 +41,28 @@
*/
public class MiniBatchDeduplicateKeepLastRowFunctionTest extends
DeduplicateFunctionTestBase {
- private TypeSerializer<BaseRow> typeSerializer =
inputRowType.createSerializer(new ExecutionConfig());
+ private TypeSerializer<BaseRow> typeSerializer = inputRowType
+ .createSerializer(new ExecutionConfig());
- private MiniBatchDeduplicateKeepLastRowFunction createFunction(boolean
generateRetraction) {
- return new
MiniBatchDeduplicateKeepLastRowFunction(inputRowType, generateRetraction,
typeSerializer);
+ private MiniBatchDeduplicateKeepLastRowFunction createFunction(boolean
generateRetraction,
+ long minRetentionTime) {
+ return new
MiniBatchDeduplicateKeepLastRowFunction(inputRowType, generateRetraction,
+ typeSerializer, minRetentionTime);
}
private OneInputStreamOperatorTestHarness<BaseRow, BaseRow>
createTestHarness(
- MiniBatchDeduplicateKeepLastRowFunction func)
- throws Exception {
+ MiniBatchDeduplicateKeepLastRowFunction func)
+ throws Exception {
CountBundleTrigger<Tuple2<String, String>> trigger = new
CountBundleTrigger<>(3);
KeyedMapBundleOperator op = new KeyedMapBundleOperator(func,
trigger);
- return new KeyedOneInputStreamOperatorTestHarness<>(op,
rowKeySelector, rowKeySelector.getProducedType());
+ return new KeyedOneInputStreamOperatorTestHarness<>(op,
rowKeySelector,
+ rowKeySelector.getProducedType());
Review comment:
sorry, I didn't notice that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
