azagrebin commented on a change in pull request #11545:
[FLINK-16742][runtime][dist] Extend and use BashJavaUtils to start JM JVM
process and pass JVM memory args
URL: https://github.com/apache/flink/pull/11545#discussion_r400752292
##########
File path: flink-dist/src/test/bin/runBashJavaUtilsCmd.sh
##########
@@ -36,6 +36,5 @@ FLINK_DIST_JAR=`find $FLINK_TARGET_DIR -name
'flink-dist*.jar'`
. ${bin}/../../main/flink-bin/bin/config.sh > /dev/null
-output=$(runBashJavaUtilsCmd ${COMMAND} ${FLINK_CONF_DIR}
"$FLINK_TARGET_DIR/bash-java-utils.jar:$FLINK_DIST_JAR}" | tail -n 2)
-extractExecutionParams "$(echo "$output" | head -n 1)"
-extractExecutionParams "$(echo "$output" | tail -n 1)"
+output=$(runBashJavaUtilsCmd ${COMMAND} ${FLINK_CONF_DIR}
"$FLINK_TARGET_DIR/bash-java-utils.jar:$FLINK_DIST_JAR}")
+extractExecutionResults "${output}"
Review comment:
nit: it might make sense to test `extractLoggingOutputs` as well, to not do
it manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
