tzulitai commented on a change in pull request #88: Licensing final fixes / touches for 2.0.0 URL: https://github.com/apache/flink-statefun/pull/88#discussion_r401417048
########## File path: statefun-examples/statefun-ridesharing-example/statefun-ridesharing-example-simulator/src/main/resources/META-INF/licenses/LICENSE.javax.annotation-api ########## @@ -360,400 +360,3 @@ litigation relating to this License shall be subject to the jurisdiction of the Federal Courts of the Northern District of California and the state courts of the State of California, with venue lying in Santa Clara County, California. - Review comment: I think I agree with @rmetzger here. Modying the LICENSE seems risky. Relying on our NOTICE to clearly state which license we're using the dependency under the terms of, should be sufficient. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
