GJL commented on a change in pull request #11571: [FLINK-16710][runtime] Log
Upload blocks Main Thread in TaskExecutor
URL: https://github.com/apache/flink/pull/11571#discussion_r401777526
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -290,6 +295,8 @@ public TaskExecutor(
final ResourceID resourceId =
taskExecutorServices.getUnresolvedTaskManagerLocation().getResourceID();
this.jobManagerHeartbeatManager =
createJobManagerHeartbeatManager(heartbeatServices, resourceId);
this.resourceManagerHeartbeatManager =
createResourceManagerHeartbeatManager(heartbeatServices, resourceId);
+
+ this.ioExecutor = Executors.newSingleThreadExecutor(new
ExecutorThreadFactory("taskexecutor-io"));
Review comment:
I think it would be better to move this executor to `TaskManagerServices` so
that we have the option to configure it later if needed (e.g., number of
threads). What do you think, @tillrohrmann?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
