GJL commented on a change in pull request #11571: [FLINK-16710][runtime] Log
Upload blocks Main Thread in TaskExecutor
URL: https://github.com/apache/flink/pull/11571#discussion_r402361396
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -145,6 +151,10 @@ public TaskEventDispatcher getTaskEventDispatcher() {
return taskEventDispatcher;
}
+ public ExecutorService getIOExecutor() {
Review comment:
```suggestion
public Executor getIOExecutor() {
```
It's enough to return `Executor` because we do not need lifecycle management
methods from such as `shutdown()` from outside.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
