[ 
https://issues.apache.org/jira/browse/FLINK-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073349#comment-17073349
 ] 

Yun Tang commented on FLINK-16876:
----------------------------------

>From my point of view, since we did not reach an agreement where is the scope 
>of TTL time provider, it might not be so good to add that in the constructor 
>directly. It could be part of environment, which is already in the constructor 
>in the {{StreamTaskStateInitializerImpl}} or it could be part of 
>{{TtlStateFactory}} which should not be related to 
>{{StreamTaskStateInitializerImpl}} directly. I prefer to add customized mock 
>{{StreamTaskStateInitializerImpl}} or {{StateBackend}} with 
>{{TtlTimeProvider}} in constructor for unit test to walk around currently.

> Make TtlTimeProvider configurable when creating keyed state backend
> -------------------------------------------------------------------
>
>                 Key: FLINK-16876
>                 URL: https://issues.apache.org/jira/browse/FLINK-16876
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / State Backends
>    Affects Versions: 1.10.0
>            Reporter: Yun Tang
>            Priority: Major
>
> Currently, we would always use TtlTimeProvider.DEFAULT to create keyed state 
> backend. This is somehow acceptable since we only support processing time for 
> TTL now. However, this would make UT tests which would verify TTL logic not 
> so convenient like FLINK-16581.
> I propose to let TtlTimeProvider configurable when creating keyed state 
> backend to not block other feature development.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to