tillrohrmann commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r403063198
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -288,7 +288,7 @@ protected void internalDeregisterApplication(
}
@Override
- public boolean startNewWorker(ResourceProfile resourceProfile) {
+ public boolean startNewWorker(WorkerResourceSpec workerResourceSpec) {
Review comment:
I think we should ensure that `workerResourceSpec` can be fulfilled by the
actual container size the `YarnResourceManager` starts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
