tillrohrmann commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r403032569
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -133,14 +133,17 @@
@Nullable
private final WorkerResourceSpec defaultWorkerResourceSpec;
+ private final int numSlotsPerWorker;
+
public SlotManagerImpl(
SlotMatchingStrategy slotMatchingStrategy,
ScheduledExecutor scheduledExecutor,
Time taskManagerRequestTimeout,
Time slotRequestTimeout,
Time taskManagerTimeout,
boolean waitResultConsumedBeforeRelease,
- @Nullable WorkerResourceSpec defaultWorkerResourceSpec)
{
+ @Nullable WorkerResourceSpec defaultWorkerResourceSpec,
+ int numSlotsPerWorker) {
Review comment:
Maybe it would make sense to pass in the `SlotManagerConfiguration`. If this
is possible, then one would not have to add another field to the constructor
every time we add a new configuration parameter for the `SlotManager`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
