tillrohrmann commented on a change in pull request #11353: [FLINK-16438][yarn]
Make YarnResourceManager starts workers using WorkerResourceSpec requested by
SlotManager
URL: https://github.com/apache/flink/pull/11353#discussion_r403105830
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -615,4 +632,85 @@ protected double getCpuCores(final Configuration
configuration) {
//noinspection NumericCastThatLosesPrecision
return cpuCoresLong;
}
+
+ /**
+ * Utility class for converting between Flink {@link
WorkerResourceSpec} and Yarn {@link Resource}.
+ */
+ @VisibleForTesting
+ static class WorkerSpecContainerResourceAdapter {
+ private final Configuration flinkConfig;
+ private final int minMemMB;
+ private final int minVcore;
+ private final boolean matchVcores;
+ private final Map<WorkerResourceSpec, Resource>
workerSpecToContainerResource;
+ private final Map<Resource, Collection<WorkerResourceSpec>>
containerResourceToWorkerSpecs;
Review comment:
If we are interested in every `WorkerResourceSpec` which ever resulted into
a given `Resource`, then I would suggest to change the value type to `List`.
Otherwise one could instantiate this field with a `Set` which has different
semantics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
