twalthr commented on a change in pull request #11570: [FLINK-16830][table-api]
Let users use Row/List/Map/Seq directly in Expression DSL
URL: https://github.com/apache/flink/pull/11570#discussion_r404028631
##########
File path:
flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/expressionDsl.scala
##########
@@ -425,54 +388,29 @@ trait ImplicitExpressionConversions {
implicit def localDateTime2Literal(localDateTime: LocalDateTime): Expression
=
valueLiteral(localDateTime)
+ implicit def jList2ArrayConstructor(jList: JList[_]): Expression = {
+ ApiExpressionUtils.objectToExpression(jList)
+ }
+
+ implicit def seq2ArrayConstructor(seq: Seq[_]): Expression = {
+ ApiExpressionUtils.objectToExpression(seq)
+ }
+
implicit def array2ArrayConstructor(array: Array[_]): Expression = {
+ ApiExpressionUtils.objectToExpression(array)
+ }
- def createArray(elements: Array[_]): Expression = {
- unresolvedCall(BuiltInFunctionDefinitions.ARRAY,
elements.map(valueLiteral): _*)
- }
+ implicit def map2MapConstructor(map: JMap[_, _]): Expression = {
Review comment:
nit: `javaMap2MapConstructor `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
