twalthr commented on a change in pull request #11570: [FLINK-16830][table-api]
Let users use Row/List/Map/Seq directly in Expression DSL
URL: https://github.com/apache/flink/pull/11570#discussion_r404046891
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/validation/ScalarOperatorsValidationTest.scala
##########
@@ -43,7 +43,7 @@ class ScalarOperatorsValidationTest extends
ScalarOperatorsTestBase {
@Test(expected = classOf[ValidationException])
def testInvalidStringComparison2(): Unit = {
- testTableApi("w" > 4.toExpr, "FAIL", "FAIL")
+ testTableApi("w".toExpr > 4.toExpr, "FAIL", "FAIL")
Review comment:
nit: it would be interesting to understand why this is necessary now? if we
do with this regression, I would at least remove the right `toExpr` call
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
