tillrohrmann commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r404082884
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -1054,10 +1054,10 @@ protected abstract void internalDeregisterApplication(
* Allocates a resource using the resource profile.
*
* @param resourceProfile The resource description
- * @return Collection of {@link ResourceProfile} describing the
launched slots
+ * @return whether the resource can be allocated
*/
@VisibleForTesting
- public abstract Collection<ResourceProfile>
startNewWorker(ResourceProfile resourceProfile);
+ public abstract boolean startNewWorker(ResourceProfile resourceProfile);
Review comment:
Ok if I understand it correctly, then this PR relies on the fact that the
`RM` and the `SlotManager` both get the same (implicitly or explicitly)
`WorkerResourceSpec` assigned, right?
I think it can still happen that the RM won't be able to start exactly a
container of the size `WorkerResourceSpec`, even after later changes. Imagine
that we are on Yarn were the requested `WorkerResourceSpec` is below the
minimum. How should Flink behave in this situation? Should we fail? Should we
leave some of the resources unused? Or should we tell the `SlotManager` about
it so that it can take the additional resources into account?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
