zhijiangW commented on issue #11515: [FLINK-16744][task] implement channel 
state persistence for unaligned checkpoints
URL: https://github.com/apache/flink/pull/11515#issuecomment-610463783
 
 
   I guess these two commits "[FLINK-16744][task][refactor] extract 
SubtaskCheckpointCoordinator" and "[FLINK-16744][task][refactor] inline 
CheckpointingOperation" can be finalized to squash to make the 
`SubtaskCheckpointCoordinator` complete. WDYT?
   
   Besides that, it is better to adjust the commit title and message formally. 
   - Make the first letter in upper case for commit title
   - Make an empty line between commit title and content
   - Give more information in some commit title, e.g. ` 
[FLINK-16744][task][test][hotfix] fix formatting`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to