Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1450#discussion_r47632106
--- Diff:
flink-yarn/src/main/scala/org/apache/flink/yarn/YarnJobManager.scala ---
@@ -754,6 +538,243 @@ class YarnJobManager(
memoryLimit
}
}
+
+ /**
+ * Heartbeats with the resource manager and handles container updates.
+ */
+ object AMRMClientAsyncHandler extends AMRMClientAsync.CallbackHandler {
+
+ private var client : AMRMClientAsync[ContainerRequest] = null
+
+ override def onError(e: Throwable): Unit = {
+ self ! decorateMessage(
+ StopYarnSession(
+ FinalApplicationStatus.FAILED,
+ "Error in communication with Yarn resource manager: " +
e.getMessage)
+ )
+ }
+
+ override def getProgress: Float = {
+ runningContainers.toFloat / numTaskManagers
+ }
+
+ override def onShutdownRequest(): Unit = {
+ }
+
+ override def onNodesUpdated(updatedNodes: JavaList[NodeReport]): Unit
= {
+ }
+
+ override def onContainersCompleted(statuses:
JavaList[ContainerStatus]): Unit = {
+
+ // TODO change this
--- End diff --
I wanted to remove the debug message here because heartbeat messages are
processed in the heartbeat thread and logging a heartbeat on a callback does
not really make sense. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
