Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1450#discussion_r47656011
  
    --- Diff: 
flink-yarn/src/main/scala/org/apache/flink/yarn/YarnJobManager.scala ---
    @@ -155,12 +156,14 @@ class YarnJobManager(
     
           rmClientOption foreach {
             rmClient =>
    -          Try(rmClient.unregisterApplicationMaster(status, diag, 
"")).recover{
    +          Try(rmClient.unregisterApplicationMaster(status, diag, 
"")).recover {
    +            // https://issues.apache.org/jira/browse/YARN-1842
    +            case e : InvalidApplicationMasterRequestException =>
    --- End diff --
    
    Okay, I think the cleaner solution is to ignore the shutdown request 
callback. This changes nothing about the current behavior of the YarnJobManager 
and keeps the code clean of such unfortunate workarounds. Do you approve?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to