dianfu commented on a change in pull request #11682: [FLINK-16668][python]
Refactor PythonDriver to read python dependency info both from command line and
environment configuration.
URL: https://github.com/apache/flink/pull/11682#discussion_r406588461
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
##########
@@ -124,29 +124,29 @@
public static final Option STOP_AND_DRAIN = new Option("d", "drain",
false,
"Send MAX_WATERMARK before taking the savepoint and
stopping the pipelne.");
- static final Option PY_OPTION = new Option("py", "python", true,
+ public static final Option PY_OPTION = new Option("py", "python", true,
"Python script with the program entry point. " +
"The dependent resources can be configured with the
`--pyFiles` option.");
- static final Option PYFILES_OPTION = new Option("pyfs", "pyFiles", true,
+ public static final Option PYFILES_OPTION = new Option("pyfs",
"pyFiles", true,
"Attach custom python files for job. " +
"These files will be added to the PYTHONPATH of both
the local client and the remote python UDF worker. " +
"The standard python resource file suffixes such as
.py/.egg/.zip or directory are all supported. " +
"Comma (',') could be used as the separator to specify
multiple files " +
"(e.g.: --pyFiles
file:///tmp/myresource.zip,hdfs:///$namenode_address/myresource2.zip).");
- static final Option PYMODULE_OPTION = new Option("pym", "pyModule",
true,
+ public static final Option PYMODULE_OPTION = new Option("pym",
"pyModule", true,
"Python module with the program entry point. " +
"This option must be used in conjunction with
`--pyFiles`.");
- static final Option PYREQUIREMENTS_OPTION = new Option("pyreq",
"pyRequirements", true,
+ public static final Option PYREQUIREMENTS_OPTION = new Option("pyreq",
"pyRequirements", true,
"Specify a requirements.txt file which defines the third-party
dependencies. " +
"These dependencies will be installed and added to the
PYTHONPATH of the python UDF worker. " +
"A directory which contains the installation packages
of these dependencies could be specified " +
"optionally. Use '#' as the separator if the optional
parameter exists " +
"(e.g.: --pyRequirements
file:///tmp/requirements.txt#file:///tmp/cached_dir).");
- static final Option PYARCHIVE_OPTION = new Option("pyarch",
"pyArchives", true,
+ public static final Option PYARCHIVE_OPTION = new Option("pyarch",
"pyArchives", true,
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
