dianfu commented on a change in pull request #11682: [FLINK-16668][python]
Refactor PythonDriver to read python dependency info both from command line and
environment configuration.
URL: https://github.com/apache/flink/pull/11682#discussion_r406591224
##########
File path:
flink-python/src/main/java/org/apache/flink/client/python/PythonDriverEnvUtils.java
##########
@@ -37,34 +36,31 @@
import java.nio.file.SimpleFileVisitor;
import java.nio.file.attribute.BasicFileAttributes;
import java.util.ArrayList;
-import java.util.Collection;
+import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.UUID;
+import java.util.stream.Collectors;
+
+import static org.apache.flink.python.PythonOptions.PYTHON_CLIENT_EXECUTABLE;
+import static org.apache.flink.python.PythonOptions.PYTHON_FILES;
+import static
org.apache.flink.python.util.PythonDependencyUtils.FILE_DELIMITER;
/**
* The util class help to prepare Python env and run the python process.
*/
public final class PythonDriverEnvUtils {
private static final Logger LOG =
LoggerFactory.getLogger(PythonDriverEnvUtils.class);
- private static final String FLINK_OPT_DIR =
System.getenv(ConfigConstants.ENV_FLINK_OPT_DIR);
-
- private static final String FLINK_OPT_DIR_PYTHON = FLINK_OPT_DIR +
File.separator + "python";
-
@VisibleForTesting
- public static final String PYFLINK_PY_FILES = "PYFLINK_PY_FILES";
+ static Map<String, String> systemEnv = System.getenv();
Review comment:
Just call `System.getenv()` when need to access the system variables?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
