Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1465#issuecomment-165462700
Thanks for your feedback @tillrohrmann.
Many parts could be expressed in more Scala style, but for performance
reasons and to prevent bugs in this crucial component I chose simple while
loops and tried to be as close as possible to already proven code (esp.
TupleSerializerBase and Fabians NullMaskSerDeUtils). In FLINK-2203 @aljoscha
already mentioned that: "Could you please change this back to the simple while
loop. I know that using the fancy Scala features is tempting but the
performance of a simple while loop should be better than creating a range and
iterating over it using foreach."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
