azagrebin commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-612981175 Thanks for addressing the comments @wangyang0918 I also changed a bit test to wait for the actual pod creation with the latch and reduced the retry interval for tests to keep test run time low. One hotfix commit introduces `KubernetesResourceManagerConfiguration`. It is created by factory and injected into the `KubernetesResourceManager`. Ideally, there should be no logic in constructor but in factories. The object should get only needed dependencies to simplify mocking them in tests. If you are ok with my additions, the PR looks good to me.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
