azagrebin commented on issue #11427: [FLINK-15790][k8s] Make FlinkKubeClient and its implementations asynchronous URL: https://github.com/apache/flink/pull/11427#issuecomment-613416114 @wangyang0918 I would suggest one more follow-up. We call `FlinkKubeClient#stopAndCleanupCluster` in `KubernetesResourceManager#internalDeregisterApplication` which is an abstract method of `ResourceManager` called from `deregisterApplication`. The `deregisterApplication` is async. We could easily make the abstract method `ResourceManager#internalDeregisterApplication` also async and return its result future from `deregisterApplication`, also with logging in case of error. All other implementations does not have to be async, they could simply return `CompletableFuture.completedFuture(Acknowledge.get())` for now.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
