zenfenan commented on issue #11474: FLINK-10114: Add ORC BulkWriter support for StreamingFileSink URL: https://github.com/apache/flink/pull/11474#issuecomment-612987289 @kl0u Not at all. In fact, I have added `appendUserMetadata()` already in the latest commit which I pushed yesterday. As I have mentioned in yesterday's comment, I don't think it can be added to the `Vectorizer` since the Writer wouldn't be created just yet. However, we can have it in the OrcBulkWriterFactory so I added that method there. Yesterday's commit also introduces creating the `VectorizedRowBatch` & handling its lifecycle within the `OrcBulkWriter` lifecycle and also addresses the requirement to provide the schema twice. Would appreciate if you could take a look at the changes. And yes, I think we can move it `flink-orc` module. Some changes may have to be done since I believe the ORC dependency version between this new module and `flink-orc` is different. I'll do them.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
