dianfu commented on a change in pull request #11702:
[FLINK-16667][python][client] Support new Python dependency configuration
options in flink-client.
URL: https://github.com/apache/flink/pull/11702#discussion_r407976703
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
##########
@@ -176,20 +176,15 @@ protected void run(String[] args) throws Exception {
final Options commandOptions =
CliFrontendParser.getRunCommandOptions();
final CommandLine commandLine = getCommandLine(commandOptions,
args, true);
- final ProgramOptions programOptions = new
ProgramOptions(commandLine);
+ final ProgramOptions programOptions =
ProgramOptions.create(commandLine);
// evaluate help flag
if (commandLine.hasOption(HELP_OPTION.getOpt())) {
CliFrontendParser.printHelpForRun(customCommandLines);
return;
}
- if (!programOptions.isPython()) {
- // Java program should be specified a JAR file
- if (programOptions.getJarFilePath() == null) {
- throw new CliArgsException("Java program should
be specified a JAR file.");
- }
- }
+ programOptions.validate();
Review comment:
The validate could be removed as it will be executed in buildProgram
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
