dianfu commented on a change in pull request #11702:
[FLINK-16667][python][client] Support new Python dependency configuration
options in flink-client.
URL: https://github.com/apache/flink/pull/11702#discussion_r407978207
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/ProgramOptions.java
##########
@@ -22,43 +22,36 @@
import org.apache.flink.runtime.jobgraph.SavepointRestoreSettings;
import org.apache.commons.cli.CommandLine;
-import org.apache.commons.cli.Option;
import java.net.MalformedURLException;
import java.net.URL;
import java.util.ArrayList;
import java.util.Arrays;
-import java.util.HashSet;
import java.util.List;
-import java.util.Set;
import static org.apache.flink.client.cli.CliFrontendParser.ARGS_OPTION;
import static org.apache.flink.client.cli.CliFrontendParser.CLASSPATH_OPTION;
import static org.apache.flink.client.cli.CliFrontendParser.CLASS_OPTION;
import static org.apache.flink.client.cli.CliFrontendParser.DETACHED_OPTION;
import static org.apache.flink.client.cli.CliFrontendParser.JAR_OPTION;
import static org.apache.flink.client.cli.CliFrontendParser.PARALLELISM_OPTION;
-import static org.apache.flink.client.cli.CliFrontendParser.PYARCHIVE_OPTION;
-import static org.apache.flink.client.cli.CliFrontendParser.PYEXEC_OPTION;
-import static org.apache.flink.client.cli.CliFrontendParser.PYFILES_OPTION;
-import static org.apache.flink.client.cli.CliFrontendParser.PYMODULE_OPTION;
-import static
org.apache.flink.client.cli.CliFrontendParser.PYREQUIREMENTS_OPTION;
-import static org.apache.flink.client.cli.CliFrontendParser.PY_OPTION;
import static
org.apache.flink.client.cli.CliFrontendParser.SHUTDOWN_IF_ATTACHED_OPTION;
import static
org.apache.flink.client.cli.CliFrontendParser.YARN_DETACHED_OPTION;
+import static
org.apache.flink.client.cli.PythonProgramOptions.containsPythonDependency;
+import static org.apache.flink.client.cli.PythonProgramOptions.isPython;
/**
* Base class for command line options that refer to a JAR file program.
*/
public class ProgramOptions extends CommandLineOptions {
- private final String jarFilePath;
+ private String jarFilePath;
- private final String entryPointClass;
+ protected String entryPointClass;
private final List<URL> classpaths;
- private final String[] programArgs;
Review comment:
unnecessary change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
