wuchong commented on a change in pull request #11466: [FLINK-15400][connectors
/ elasticsearch] elasticsearch table sink support dynamic index.
URL: https://github.com/apache/flink/pull/11466#discussion_r408616904
##########
File path:
flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch6/ElasticsearchSink.java
##########
@@ -61,15 +63,24 @@
public class ElasticsearchSink<T> extends ElasticsearchSinkBase<T,
RestHighLevelClient> {
private static final long serialVersionUID = 1L;
+ private final IndexGenerator indexGenerator;
Review comment:
We shouldn't add `IndexGenerator` here. Generating index is the
responsibility of `ElasticsearchSinkFunction`. We can add an default empty
`open` method in `ElasticsearchSinkFunction` to avoid putting `IndexGenerator`
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
