wuchong commented on a change in pull request #11466: [FLINK-15400][connectors
/ elasticsearch] elasticsearch table sink support dynamic index.
URL: https://github.com/apache/flink/pull/11466#discussion_r401377483
##########
File path:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchUpsertTableSinkBase.java
##########
@@ -422,6 +427,7 @@ DeleteRequest createDeleteRequest(
private final XContentType contentType;
private final RequestFactory requestFactory;
private final int[] keyFieldIndices;
+ private final IndexGenerator indexGenerator;
public ElasticsearchUpsertSinkFunction(
String index,
Review comment:
I think we can remove `index` parameter now, it is never used, and put
`indexGenerator` as the first parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
