tillrohrmann commented on a change in pull request #11320: 
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager 
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r408959570
 
 

 ##########
 File path: 
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManager.java
 ##########
 @@ -267,10 +267,9 @@ private void requestKubernetesPod() {
         * Request new pod if pending pods cannot satisfy pending slot requests.
         */
        private void requestKubernetesPodIfRequired() {
-               final int requiredTaskManagerSlots = 
getNumberRequiredTaskManagerSlots();
-               final int pendingTaskManagerSlots = numPendingPodRequests * 
numSlotsPerTaskManager;
+               int requiredTaskManagers = getNumberRequiredTaskManagers();
 
 Review comment:
   ```suggestion
                final int requiredTaskManagers = 
getNumberRequiredTaskManagers();
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to