tillrohrmann commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r409483913
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/PerJobMiniClusterFactory.java
##########
@@ -100,8 +100,10 @@ private MiniClusterConfiguration getMiniClusterConfig(int
maximumParallelism) {
ConfigConstants.LOCAL_NUMBER_TASK_MANAGER,
ConfigConstants.DEFAULT_LOCAL_NUMBER_TASK_MANAGER);
- // we have to use the maximum parallelism as a default here,
otherwise streaming pipelines would not run
- int numSlotsPerTaskManager =
configuration.getInteger(TaskManagerOptions.NUM_TASK_SLOTS, maximumParallelism);
+ int numSlotsPerTaskManager =
configuration.getOptional(TaskManagerOptions.NUM_TASK_SLOTS)
+ .orElseGet(() -> maximumParallelism > 0 ?
+ (int) Math.ceil((double) maximumParallelism /
numTaskManagers) :
Review comment:
Can't we use `MathUtils.divideRoundUp` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
