tillrohrmann commented on a change in pull request #11353: [FLINK-16438][yarn]
Make YarnResourceManager starts workers using WorkerResourceSpec requested by
SlotManager
URL: https://github.com/apache/flink/pull/11353#discussion_r409627647
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/RegisterApplicationMasterResponseReflectorTest.java
##########
@@ -88,7 +94,44 @@ public void testGetMethodReflectiveHadoop22() {
final RegisterApplicationMasterResponseReflector
registerApplicationMasterResponseReflector =
new RegisterApplicationMasterResponseReflector(LOG);
- final Method method =
registerApplicationMasterResponseReflector.getMethod();
+ final Method method =
registerApplicationMasterResponseReflector.getGetContainersFromPreviousAttemptsMethod();
+ assertThat(method, notNullValue());
+ }
+
+ @Test
+ public void testCallsGetSchedulerResourceTypesMethodIfPresent() {
+ final RegisterApplicationMasterResponseReflector
registerApplicationMasterResponseReflector =
+ new RegisterApplicationMasterResponseReflector(LOG,
HasMethod.class);
+
+ final Optional<Set<String>> schedulerResourceTypeNames =
+
registerApplicationMasterResponseReflector.getSchedulerResourceTypeNamesUnsafe(new
HasMethod());
Review comment:
Instead of calling private methods of the
`RegisterApplicationMasterResponseReflector` we could also add an `assumeTrue`
statement based on the Hadoop version. Then we can have two tests for Hadoop >=
2.6 and < 2.6.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
