tillrohrmann commented on a change in pull request #11353: [FLINK-16438][yarn]
Make YarnResourceManager starts workers using WorkerResourceSpec requested by
SlotManager
URL: https://github.com/apache/flink/pull/11353#discussion_r409630377
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -117,7 +118,9 @@
/** Client to communicate with the Node manager and launch TaskExecutor
processes. */
private NMClientAsync nodeManagerClient;
- private final WorkerSpecContainerResourceAdapter
workerSpecContainerResourceAdapter;
+ private WorkerSpecContainerResourceAdapter
workerSpecContainerResourceAdapter = null;
Review comment:
An idea to keep the `WorkerSpecContainerResourceAdapter` final is to pass in
the `WorkerSpecContainerResourceAdapter.MatchingStrategy` to the method
`getWorkerSpecs`. If you look at the `WorkerSpecContainerResourceAdapter` class
then one also sees that the matching strategy is not really an essential part
of it. Only the lookup method changes its behaviour based on it. Everything
else stays the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
