twalthr commented on a change in pull request #11290: [FLINK-16379][table]
Introduce fromValues in TableEnvironment
URL: https://github.com/apache/flink/pull/11290#discussion_r410058342
##########
File path:
flink-table/flink-table-common/src/test/java/org/apache/flink/table/expressions/ExpressionTest.java
##########
@@ -281,6 +281,12 @@ public void testPeriodValueLiteralExtraction() {
//
--------------------------------------------------------------------------------------------
private static Expression createExpressionTree(Integer nestedValue) {
+ final ValueLiteralExpression nestedLiteral;
+ if (nestedValue != null) {
+ nestedLiteral = new ValueLiteralExpression(nestedValue,
DataTypes.INT().notNull());
Review comment:
nit: add a `@Nullable` annotation to `ValueLiteralExpression` constructor
parameters
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
