twalthr commented on a change in pull request #11290: [FLINK-16379][table]
Introduce fromValues in TableEnvironment
URL: https://github.com/apache/flink/pull/11290#discussion_r410057386
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/ValueLiteralExpression.java
##########
@@ -266,6 +266,11 @@ private static void validateValueDataType(Object value,
DataType dataType) {
}
return;
}
+
+ if (logicalType.isNullable()) {
+ throw new ValidationException("Data type for non null
literals must not be nullable.");
Review comment:
nit: `Literals that have a non-null value must not have a nullable data
type.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
