godfreyhe commented on a change in pull request #11727: [FLINK-17106][table] Support create and drop view in Flink SQL URL: https://github.com/apache/flink/pull/11727#discussion_r410059591
########## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/CreateViewOperation.java ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.operations.ddl; + +import org.apache.flink.table.catalog.CatalogView; +import org.apache.flink.table.catalog.ObjectIdentifier; +import org.apache.flink.table.operations.Operation; +import org.apache.flink.table.operations.OperationUtils; + +import java.util.Collections; +import java.util.LinkedHashMap; +import java.util.Map; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +/** + * Operation to describe a CREATE VIEW statement. + */ +public class CreateViewOperation implements CreateOperation { + private final ObjectIdentifier viewIdentifier; + private CatalogView catalogView; + private boolean ignoreIfExists; + private boolean isTemporary; + + public CreateViewOperation( + ObjectIdentifier viewIdentifier, + CatalogView catalogView, + boolean ignoreIfExists, + boolean isTemporary) { + this.viewIdentifier = viewIdentifier; + this.catalogView = catalogView; + this.ignoreIfExists = ignoreIfExists; + this.isTemporary = isTemporary; + } + + public CatalogView getCatalogView() { + return catalogView; + } + + public ObjectIdentifier getViewIdentifier() { + return viewIdentifier; + } + + public boolean isIgnoreIfExists() { + return ignoreIfExists; + } + + public boolean isTemporary() { + return isTemporary; + } + + @Override + public String asSummaryString() { + Map<String, Object> params = new LinkedHashMap<>(); Review comment: directly use `params.put` ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
