godfreyhe commented on a change in pull request #11727: [FLINK-17106][table]
Support create and drop view in Flink SQL
URL: https://github.com/apache/flink/pull/11727#discussion_r410067059
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/catalog/CatalogTableITCase.scala
##########
@@ -877,6 +877,397 @@ class CatalogTableITCase(isStreamingMode: Boolean)
extends AbstractTestBase {
expectedProperty.put("k2", "b")
assertEquals(expectedProperty, database.getProperties)
}
+
+ @Test
+ def testCreateViewIfNotExistsTwice(): Unit = {
+ val sourceData = List(
+ toRow(1, "1000", 2),
+ toRow(2, "1", 3),
+ toRow(3, "2000", 4),
+ toRow(1, "2", 2),
+ toRow(2, "3000", 3))
+
+ TestCollectionTableFactory.initData(sourceData)
+
+ val sourceDDL =
+ """
+ |CREATE TABLE T1(
+ | a int,
+ | b varchar,
+ | c int
+ |) with (
+ | 'connector' = 'COLLECTION'
+ |)
+ """.stripMargin
+
+ val sinkDDL =
+ """
+ |CREATE TABLE T2(
+ | a int,
+ | b varchar,
+ | c int
+ |) with (
+ | 'connector' = 'COLLECTION'
+ |)
+ """.stripMargin
+
+ val viewWith3ColumnDDL =
+ """
+ |CREATE VIEW IF NOT EXISTS T3(d, e, f) AS SELECT a, b, c FROM T1
+ """.stripMargin
+
+ val viewWith2ColumnDDL =
+ """
+ |CREATE VIEW IF NOT EXISTS T3(d, e) AS SELECT a, b FROM T1
+ """.stripMargin
+
+ val query = "SELECT d, e, f FROM T3"
+
+ tableEnv.sqlUpdate(sourceDDL)
+ tableEnv.sqlUpdate(sinkDDL)
+ tableEnv.sqlUpdate(viewWith3ColumnDDL)
+ tableEnv.sqlUpdate(viewWith2ColumnDDL)
+
+ val result = tableEnv.sqlQuery(query)
+ result.insertInto("T2")
+ execJob("testJob")
+ assertEquals(sourceData.sorted, TestCollectionTableFactory.RESULT.sorted)
+ }
+
+ @Test(expected = classOf[ValidationException])
+ def testCreateViewTwice(): Unit = {
+ val sourceDDL =
+ """
+ |CREATE TABLE T1(
+ | a int,
+ | b varchar,
+ | c int
+ |) with (
+ | 'connector' = 'COLLECTION'
+ |)
+ """.stripMargin
+
+ val sinkDDL =
+ """
+ |CREATE TABLE T2(
+ | a int,
+ | b varchar,
+ | c int
+ |) with (
+ | 'connector' = 'COLLECTION'
+ |)
+ """.stripMargin
+
+ val viewWith3ColumnDDL =
+ """
+ |CREATE VIEW T3(d, e, f) AS SELECT a, b, c FROM T1
+ """.stripMargin
+
+ val viewWith2ColumnDDL =
+ """
+ |CREATE VIEW T3(d, e) AS SELECT a, b FROM T1
+ """.stripMargin
+
+ tableEnv.sqlUpdate(sourceDDL)
+ tableEnv.sqlUpdate(sinkDDL)
+ tableEnv.sqlUpdate(viewWith3ColumnDDL)
+ tableEnv.sqlUpdate(viewWith2ColumnDDL) // fail the case
+ }
+
Review comment:
nit: redundant blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
