Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1480#discussion_r48659074
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/DataSet.scala ---
@@ -89,7 +89,7 @@ class DataSet[T: ClassTag](set: JavaDataSet[T]) {
/**
* Returns the TypeInformation for the elements of this DataSet.
*/
- def getType(): TypeInformation[T] = set.getType()
--- End diff --
We need to actually define in the code style whether we call Java functions
with or without parenthesis.
Last time we discussed that, we concluded that since Java functions do not
declare side-effect-freeness, may be good to always keep the parenthesis. Plus,
for getters this always seemed strange to me. Methods without parenthesis are
Scala's style of blurring the boundaries between methods and variables. But for
something that is explicitly named like a method (`getType()` rather than
`type()`) it looks weird to try and treat it like a variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
