pnowojski commented on a change in pull request #11687:
URL: https://github.com/apache/flink/pull/11687#discussion_r411481437



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGate.java
##########
@@ -131,7 +135,12 @@
        /**
         * Setup gate, potentially heavy-weight, blocking operation comparing 
to just creation.
         */
-       public abstract void setup() throws IOException, InterruptedException;
+       public abstract void setup() throws IOException;
+
+       public abstract void initializeStateAndRequestPartitions(

Review comment:
       ok, we can keep it consistent (we could also rename it in the partitions 
;) ). `initializeState` sounds to me more  like we are trying to initialize a 
state and keep using it later on (like in operators). `readState` better 
carries out the intention that the state is only used once.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to