leonardBang commented on a change in pull request #11334:
URL: https://github.com/apache/flink/pull/11334#discussion_r411265633
##########
File path: flink-table/flink-sql-client/src/main/resources/META-INF/NOTICE
##########
@@ -9,3 +9,4 @@ See bundled license files for details.
- org.jline:jline-terminal:3.9.0
- org.jline:jline-reader:3.9.0
+- com.ibm.icu:icu4j:65.1
Review comment:
@aljoscha Thanks for your feedback, you're wright that icu is not a pure
BSD license, I hesitate to import it at the beginning, but decided to add it
after references `hive`
https://github.com/apache/hive/blob/master/binary-package-licenses/com.ibm.icu.icu4j-LICENSE
##########
File path: flink-table/flink-sql-client/src/main/resources/META-INF/NOTICE
##########
@@ -9,3 +9,4 @@ See bundled license files for details.
- org.jline:jline-terminal:3.9.0
- org.jline:jline-reader:3.9.0
+- com.ibm.icu:icu4j:65.1
Review comment:
And `camel` using it too
,https://github.com/apache/camel/commit/83ae6d4e30387894b61c0799251e429a81b39435
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
