zentol commented on a change in pull request #12:
URL: https://github.com/apache/flink-docker/pull/12#discussion_r412849395
##########
File path: docker-entrypoint.sh
##########
@@ -56,6 +56,21 @@ copy_plugins_if_required() {
done
}
+set_config_option() {
+ local option=$1
+ local value=$2
+
+ # escape periods for usage in regular expressions
+ local escaped_option=$(echo ${option} | sed -e "s/\./\\\./g")
+
+ # either override an existing entry, or append a new one
+ if grep -E "^${escaped_option}:.*" "${CONF_FILE}}" > /dev/null; then
+ sed -i -e "s/${escaped_option}:.*/$option: $value/g" "${CONF_FILE}"
Review comment:
There is no difference between mounting a custom config and the current
`FLINK_PROPERTIES` approach in terms of how we need to handle things.
Take shipped flink-conf.yaml, set various options by default, merge custom
config into shipped flink-conf.yaml.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
