zentol commented on a change in pull request #12:
URL: https://github.com/apache/flink-docker/pull/12#discussion_r412851544
##########
File path: docker-entrypoint.sh
##########
@@ -64,23 +79,9 @@ elif [ "$1" = "jobmanager" ]; then
echo "Starting Job Manager"
copy_plugins_if_required
- if grep -E "^jobmanager\.rpc\.address:.*" "${CONF_FILE}" > /dev/null; then
- sed -i -e "s/jobmanager\.rpc\.address:.*/jobmanager.rpc.address:
${JOB_MANAGER_RPC_ADDRESS}/g" "${CONF_FILE}"
- else
- echo "jobmanager.rpc.address: ${JOB_MANAGER_RPC_ADDRESS}" >>
"${CONF_FILE}"
- fi
-
- if grep -E "^blob\.server\.port:.*" "${CONF_FILE}" > /dev/null; then
- sed -i -e "s/blob\.server\.port:.*/blob.server.port: 6124/g"
"${CONF_FILE}"
- else
- echo "blob.server.port: 6124" >> "${CONF_FILE}"
- fi
-
- if grep -E "^query\.server\.port:.*" "${CONF_FILE}" > /dev/null; then
- sed -i -e "s/query\.server\.port:.*/query.server.port: 6125/g"
"${CONF_FILE}"
- else
- echo "query.server.port: 6125" >> "${CONF_FILE}"
- fi
+ set_config_option jobmanager.rpc.address ${JOB_MANAGER_RPC_ADDRESS}
+ set_config_option blob.server.port 6124
+ set_config_option query.server.port 6125
Review comment:
I suppose we could introduce a shared method for the rpc address and
ports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
