zentol commented on a change in pull request #11838:
URL: https://github.com/apache/flink/pull/11838#discussion_r413650814
##########
File path: flink-metrics/flink-metrics-graphite/pom.xml
##########
@@ -65,31 +65,4 @@ under the License.
<version>${dropwizard.version}</version>
</dependency>
</dependencies>
-
- <build>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-shade-plugin</artifactId>
- <executions>
- <execution>
- <id>shade-flink</id>
- <phase>package</phase>
- <goals>
- <goal>shade</goal>
- </goals>
- <configuration>
- <artifactSet>
- <includes>
-
<include>org.apache.flink:flink-metrics-dropwizard</include>
-
<include>io.dropwizard.metrics:metrics-core</include>
Review comment:
So this is where terminology is the name of the game. Forget the term
"shading", because it is quite ambiguous.
We do not need to _relocate_ any dependency, but we still want to _bundle_
them in the jar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
