azagrebin commented on a change in pull request #11109:
URL: https://github.com/apache/flink/pull/11109#discussion_r413839023
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java
##########
@@ -779,20 +735,12 @@ public int getNumberOfPages() {
return numberOfPages;
}
- public Set<MemoryType> getTypes() {
- return Collections.unmodifiableSet(types);
- }
-
public static Builder newBuilder(Object owner) {
return new Builder(owner);
}
- public static AllocationRequest ofAllTypes(Object owner, int
numberOfPages) {
- return
newBuilder(owner).ofAllTypes().numberOfPages(numberOfPages).build();
- }
-
- public static AllocationRequest ofType(Object owner, int
numberOfPages, MemoryType type) {
- return
newBuilder(owner).ofType(type).numberOfPages(numberOfPages).build();
+ public static AllocationRequest forOf(Object owner, int
numberOfPages) {
Review comment:
`AllocationRequest` is removed in the next commit anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
