azagrebin commented on a change in pull request #11109:
URL: https://github.com/apache/flink/pull/11109#discussion_r413909685
##########
File path:
flink-core/src/main/java/org/apache/flink/util/JavaGcCleanerWrapper.java
##########
@@ -254,5 +339,31 @@ public Runnable create(Object owner, Runnable
cleanupOperation) {
}
};
}
+
+ @Override
+ public boolean waitForGcToRunReadyCleaners() throws
InterruptedException {
+ Object javaLangRefAccess = getJavaLangRefAccess();
+ try {
+ return (Boolean)
waitForReferenceProcessingMethod.invoke(javaLangRefAccess);
+ } catch (IllegalAccessException |
InvocationTargetException e) {
+ if (e.getCause() instanceof
InterruptedException) {
+ //noinspection
ThrowInsideCatchBlockWhichIgnoresCaughtException
+ throw (InterruptedException)
e.getCause();
+ }
Review comment:
`Java < 9` does not throw `InterruptedException` but the code should
work for both, it will just never throw `InterruptedException` for `Java < 9`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
