[
https://issues.apache.org/jira/browse/FLINK-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090650#comment-15090650
]
ASF GitHub Bot commented on FLINK-1870:
---------------------------------------
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1483#issuecomment-170244363
I understand your skeptic, but I don't see it as dangerous as you. If
somebody access this information and does not use it properly, it's his/her own
fault... (same as using a static variable in an UDF -- we cannot "protect"
users from writing bad code).
Nevertheless, originally I had the same idea as you suggest (ie, use
`processRecord()`). However, the compatibility layer also used two
`CoFlatMapFunction`s which need to access this information, too.
-
https://github.com/apache/flink/blob/master/flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/TwoFlinkStreamsMerger.java
-
https://github.com/apache/flink/blob/master/flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/StormFlinkStreamMerger.java
It would be possible to rewrite both functions as custom operators, but
this makes the translation code for multiple inputs streams more complex. Thus,
I would prefer to expose this information in `RuntimeContext`. We can also
extend the JavaDoc to warn the user to use this information carefully...
> Reintroduce Indexed reader functionality to streaming
> -----------------------------------------------------
>
> Key: FLINK-1870
> URL: https://issues.apache.org/jira/browse/FLINK-1870
> Project: Flink
> Issue Type: Task
> Components: Streaming
> Reporter: Gyula Fora
> Assignee: Matthias J. Sax
> Priority: Minor
>
> The Indexed record reader classes (IndexedReaderIterator,
> IndexedMutableReader) were introduced to allow the streaming operators to
> access the index of the last read channel from the input gate. This was a
> necessary step toward future input sorting operators.
> Unfortunately this untested feature was patched away by the following commit:
> https://github.com/apache/flink/commit/5232c56b13b7e13e2cf10dbe818c221f5557426d
> At some point we need to reimplement these features with proper tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
