[ 
https://issues.apache.org/jira/browse/FLINK-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098905#comment-15098905
 ] 

ASF GitHub Bot commented on FLINK-1870:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1483#issuecomment-171785899
  
    Right, you cannot secure users from writing bad code, of course.
    
    But a good way to guide then to writing good code is to expose only 
information they can actually use in the abstractions provided to them. 
Exposing certain information and declaring it as "don't use" is a bit like 
setting them up to make mistakes, and feels like such a strong sight that the 
abstractions are not picked correctly.
    
    If this information is needed, I would really take the custom operator 
variant. We could also think if there is a good way of circumventing to depend 
on that channel index information in the first place.


> Reintroduce Indexed reader functionality to streaming
> -----------------------------------------------------
>
>                 Key: FLINK-1870
>                 URL: https://issues.apache.org/jira/browse/FLINK-1870
>             Project: Flink
>          Issue Type: Task
>          Components: Streaming
>            Reporter: Gyula Fora
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> The Indexed record reader classes (IndexedReaderIterator, 
> IndexedMutableReader) were introduced to allow the streaming operators to 
> access the index of the last read channel from the input gate. This was a 
> necessary step toward future input sorting operators.
> Unfortunately this untested feature was patched away by the following commit:
> https://github.com/apache/flink/commit/5232c56b13b7e13e2cf10dbe818c221f5557426d
> At some point we need to reimplement these features with proper tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to